Attachment 368542 Details for Bug 197405 – Patch

[patch] Patch

bug-197405-20190430013147.patch (text/plain), 1.88 KB, created by Yusuke Suzuki on 2019-04-30 01:31:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-04-30 01:31:48 PDT

Size: 1.88 KB

patch

obsolete

>Subversion Revision: 244763
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 5778ff4fbe3694bc0bc14140680e34a04ed56f5b..79d73b20421946c138f352619d1c107af94b1ed9 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-04-30  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] Inlining Getter/Setter should care availability of ad-hocly constructed frame
>+        https://bugs.webkit.org/show_bug.cgi?id=197405
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dfg/DFGByteCodeParser.cpp:
>+        (JSC::DFG::ByteCodeParser::inlineCall):
>+
> 2019-04-29  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         Unreivewed, fix FTL implementation of r244760
>diff --git a/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp b/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
>index be99551e91d58697dcf2754b26982ca48bc775f2..7253e9a5e94754600719f774d3f9fecb17cb97b1 100644
>--- a/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
>+++ b/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
>@@ -1608,6 +1608,20 @@ void ByteCodeParser::inlineCall(Node* callTargetNode, VirtualRegister result, Ca
>         calleeVariable->mergeShouldNeverUnbox(true);
>     }
> 
>+    switch (kind) {
>+    case InlineCallFrame::GetterCall:
>+    case InlineCallFrame::SetterCall: {
>+        for (int index = 0; index < argumentCountIncludingThis; ++index) {
>+            Node* value = get(virtualRegisterForArgument(index, registerOffset));
>+            VirtualRegister argumentToSet = m_inlineStackTop->remapOperand(virtualRegisterForArgument(index, registerOffsetAfterFixup));
>+            addToGraph(MovHint, OpInfo(argumentToSet.offset()), value);
>+        }
>+        break;
>+    }
>+    default:
>+        break;
>+    }
>+
>     if (arityFixupCount) {
>         // Note: we do arity fixup in two phases:
>         // 1. We get all the values we need and MovHint them to the expected locals.

Actions: View | Formatted Diff | Diff

Attachments on bug 197405: 368542 | 368594 | 368596 | 368622 | 368627 | 368643 | 368644 | 368649 | 368650 | 368744