Attachment 368524 Details for Bug 197398 – Patch

[patch] Patch

patch197398 (text/plain), 1.27 KB, created by Robin Morisset on 2019-04-29 18:03:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-04-29 18:03:13 PDT

Size: 1.27 KB

patch

obsolete

>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 28aeca460ca..3172ceeeb27 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-04-29  Robin Morisset  <rmorisset@apple.com>
>+
>+        [B3] Tails of size 1 can be safely duplicated regardless of their number of predecessors
>+        https://bugs.webkit.org/show_bug.cgi?id=197398
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * b3/B3DuplicateTails.cpp:
>+
> 2019-04-26  Keith Rollin  <krollin@apple.com>
> 
>         Enable new build rule for post-processing headers when using XCBuild
>diff --git a/Source/JavaScriptCore/b3/B3DuplicateTails.cpp b/Source/JavaScriptCore/b3/B3DuplicateTails.cpp
>index cff44a4c1e0..4a948a44d0b 100644
>--- a/Source/JavaScriptCore/b3/B3DuplicateTails.cpp
>+++ b/Source/JavaScriptCore/b3/B3DuplicateTails.cpp
>@@ -75,7 +75,7 @@ public:
>         for (BasicBlock* block : m_proc) {
>             if (block->size() > m_maxSize)
>                 continue;
>-            if (block->numSuccessors() > m_maxSuccessors)
>+            if (block->numSuccessors() > m_maxSuccessors && block->size() != 1)
>                 continue;
>             if (block->last()->type() != Void) // Demoting doesn't handle terminals with values.
>                 continue;

Flags:

rmorisset: review-
rmorisset: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 197398: 368524