WebKit Bugzilla
Attachment 368494 Details for
Bug 197388
: <rdar://problem/50299396> Fix internal High Sierra build
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-197388-20190429143736.patch (text/plain), 17.35 KB, created by
Alex Christensen
on 2019-04-29 14:37:36 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2019-04-29 14:37:36 PDT
Size:
17.35 KB
patch
obsolete
>Index: Source/JavaScriptCore/ChangeLog >=================================================================== >--- Source/JavaScriptCore/ChangeLog (revision 244754) >+++ Source/JavaScriptCore/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Fujii Hironori <Hironori.Fujii@sony.com> > > Unreviewed, rolling out r244669. >Index: Source/JavaScriptCore/Configurations/Base.xcconfig >=================================================================== >--- Source/JavaScriptCore/Configurations/Base.xcconfig (revision 244754) >+++ Source/JavaScriptCore/Configurations/Base.xcconfig (working copy) >@@ -33,7 +33,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >Index: Source/ThirdParty/ChangeLog >=================================================================== >--- Source/ThirdParty/ChangeLog (revision 244754) >+++ Source/ThirdParty/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * gtest/xcode/Config/General.xcconfig: >+ > 2019-04-25 Alex Christensen <achristensen@webkit.org> > > Start using C++17 >Index: Source/ThirdParty/ANGLE/ChangeLog >=================================================================== >--- Source/ThirdParty/ANGLE/ChangeLog (revision 244754) >+++ Source/ThirdParty/ANGLE/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Alex Christensen <achristensen@webkit.org> > > Start using C++17 >Index: Source/ThirdParty/ANGLE/Configurations/Base.xcconfig >=================================================================== >--- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (revision 244754) >+++ Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (working copy) >@@ -10,7 +10,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >Index: Source/ThirdParty/gtest/xcode/Config/General.xcconfig >=================================================================== >--- Source/ThirdParty/gtest/xcode/Config/General.xcconfig (revision 244754) >+++ Source/ThirdParty/gtest/xcode/Config/General.xcconfig (working copy) >@@ -51,7 +51,7 @@ SEPARATE_STRIP = YES > GCC_C_LANGUAGE_STANDARD = c99 > > // Force C++14 >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > > // not sure why apple defaults this on, but it's pretty risky > ALWAYS_SEARCH_USER_PATHS = NO >Index: Source/ThirdParty/libwebrtc/ChangeLog >=================================================================== >--- Source/ThirdParty/libwebrtc/ChangeLog (revision 244754) >+++ Source/ThirdParty/libwebrtc/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Youenn Fablet <youenn@apple.com> > > Make sure sockets file descriptors are in the correct range >Index: Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig >=================================================================== >--- Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (revision 244754) >+++ Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (working copy) >@@ -12,7 +12,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_ARC = YES; > CLANG_ENABLE_OBJC_WEAK = YES; >Index: Source/WTF/ChangeLog >=================================================================== >--- Source/WTF/ChangeLog (revision 244754) >+++ Source/WTF/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Fujii Hironori <Hironori.Fujii@sony.com> > > Unreviewed, rolling out r244669. >Index: Source/WTF/Configurations/Base.xcconfig >=================================================================== >--- Source/WTF/Configurations/Base.xcconfig (revision 244754) >+++ Source/WTF/Configurations/Base.xcconfig (working copy) >@@ -33,7 +33,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_ARC = YES; > CLANG_ENABLE_OBJC_WEAK = YES; >Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 244754) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-29 Alan Coon <alancoon@apple.com> > > Cherry-pick r244696. rdar://problem/50299396 >Index: Source/WebCore/Configurations/Base.xcconfig >=================================================================== >--- Source/WebCore/Configurations/Base.xcconfig (revision 244754) >+++ Source/WebCore/Configurations/Base.xcconfig (working copy) >@@ -33,7 +33,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >Index: Source/WebCore/PAL/ChangeLog >=================================================================== >--- Source/WebCore/PAL/ChangeLog (revision 244754) >+++ Source/WebCore/PAL/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Timothy Hatcher <timothy@apple.com> > > Disable date and time inputs on iOSMac. >Index: Source/WebCore/PAL/Configurations/Base.xcconfig >=================================================================== >--- Source/WebCore/PAL/Configurations/Base.xcconfig (revision 244754) >+++ Source/WebCore/PAL/Configurations/Base.xcconfig (working copy) >@@ -33,7 +33,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >Index: Source/WebInspectorUI/ChangeLog >=================================================================== >--- Source/WebInspectorUI/ChangeLog (revision 244754) >+++ Source/WebInspectorUI/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Alex Christensen <achristensen@webkit.org> > > Start using C++17 >Index: Source/WebInspectorUI/Configurations/Base.xcconfig >=================================================================== >--- Source/WebInspectorUI/Configurations/Base.xcconfig (revision 244754) >+++ Source/WebInspectorUI/Configurations/Base.xcconfig (working copy) >@@ -17,7 +17,7 @@ DEBUG_INFORMATION_FORMAT = dwarf-with-ds > ALWAYS_SEARCH_USER_PATHS = NO; > FRAMEWORK_SEARCH_PATHS = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(inherited); > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 244754) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-29 Alan Coon <alancoon@apple.com> > > Cherry-pick r244696. rdar://problem/50299396 >Index: Source/WebKit/Configurations/Base.xcconfig >=================================================================== >--- Source/WebKit/Configurations/Base.xcconfig (revision 244754) >+++ Source/WebKit/Configurations/Base.xcconfig (working copy) >@@ -31,7 +31,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >@@ -131,7 +131,7 @@ SUPPORTS_TEXT_BASED_API[sdk=appletv*] = > SUPPORTS_TEXT_BASED_API[sdk=watch*] = NO; > > OTHER_TAPI_FLAGS = $(OTHER_TAPI_FLAGS_$(WK_COCOA_TOUCH)); >-OTHER_TAPI_FLAGS_cocoatouch = -x objective-c++ -std=c++17 -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS; >+OTHER_TAPI_FLAGS_cocoatouch = -x objective-c++ -std=gnu++1z -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS; > TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic; > > // This is required to make LLVM_TARGET_TRIPLE_SUFFIX propagate into scripts. >Index: Source/WebKitLegacy/mac/ChangeLog >=================================================================== >--- Source/WebKitLegacy/mac/ChangeLog (revision 244754) >+++ Source/WebKitLegacy/mac/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ * Configurations/WebKitLegacy.xcconfig: >+ > 2019-04-25 Timothy Hatcher <timothy@apple.com> > > Disable date and time inputs on iOSMac. >Index: Source/WebKitLegacy/mac/Configurations/Base.xcconfig >=================================================================== >--- Source/WebKitLegacy/mac/Configurations/Base.xcconfig (revision 244754) >+++ Source/WebKitLegacy/mac/Configurations/Base.xcconfig (working copy) >@@ -33,7 +33,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; >Index: Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig >=================================================================== >--- Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig (revision 244754) >+++ Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig (working copy) >@@ -140,5 +140,5 @@ WK_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_MA > SUPPORTS_TEXT_BASED_API[sdk=iphone*] = YES; > SUPPORTS_TEXT_BASED_API[sdk=appletv*] = NO; > SUPPORTS_TEXT_BASED_API[sdk=watch*] = NO; >-OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++17 -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS -exclude-private-header $(BUILT_PRODUCTS_DIR)/$(PRIVATE_HEADERS_FOLDER_PATH)/NSURLDownloadSPI.h; >+OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=gnu++1z -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS -exclude-private-header $(BUILT_PRODUCTS_DIR)/$(PRIVATE_HEADERS_FOLDER_PATH)/NSURLDownloadSPI.h; > TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic; >Index: Source/bmalloc/ChangeLog >=================================================================== >--- Source/bmalloc/ChangeLog (revision 244754) >+++ Source/bmalloc/ChangeLog (working copy) >@@ -1,3 +1,12 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/Base.xcconfig: >+ > 2019-04-25 Yusuke Suzuki <ysuzuki@apple.com> > > [bmalloc] Follow-up and fixing bug after r244481 >Index: Source/bmalloc/Configurations/Base.xcconfig >=================================================================== >--- Source/bmalloc/Configurations/Base.xcconfig (revision 244754) >+++ Source/bmalloc/Configurations/Base.xcconfig (working copy) >@@ -31,7 +31,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_ARC = YES; > CLANG_ENABLE_OBJC_WEAK = YES; >Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 244755) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ <rdar://problem/50299396> Fix internal High Sierra build >+ https://bugs.webkit.org/show_bug.cgi?id=197388 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * DumpRenderTree/mac/Configurations/Base.xcconfig: >+ * MiniBrowser/Configurations/Base.xcconfig: >+ * MobileMiniBrowser/Configurations/Base.xcconfig: >+ * TestWebKitAPI/Configurations/Base.xcconfig: >+ * WebKitTestRunner/Configurations/Base.xcconfig: >+ > 2019-04-25 Simon Fraser <simon.fraser@apple.com> > > REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures >Index: Tools/DumpRenderTree/mac/Configurations/Base.xcconfig >=================================================================== >--- Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (revision 244754) >+++ Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (working copy) >@@ -35,7 +35,7 @@ WK_PRIVATE_FRAMEWORK_STUBS_DIR_iphone_ = > > FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(WK_PRIVATE_FRAMEWORK_STUBS_DIR); > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_CXX0X_EXTENSIONS = NO; >Index: Tools/MiniBrowser/Configurations/Base.xcconfig >=================================================================== >--- Tools/MiniBrowser/Configurations/Base.xcconfig (revision 244754) >+++ Tools/MiniBrowser/Configurations/Base.xcconfig (working copy) >@@ -31,7 +31,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > GCC_PREPROCESSOR_DEFINITIONS = DISABLE_LEGACY_WEBKIT_DEPRECATIONS $(inherited); > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > DEBUG_INFORMATION_FORMAT = dwarf-with-dsym; >Index: Tools/MobileMiniBrowser/Configurations/Base.xcconfig >=================================================================== >--- Tools/MobileMiniBrowser/Configurations/Base.xcconfig (revision 244754) >+++ Tools/MobileMiniBrowser/Configurations/Base.xcconfig (working copy) >@@ -31,7 +31,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERN > > ALWAYS_SEARCH_USER_PATHS = NO; > CLANG_ANALYZER_NONNULL = YES; >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_MODULES = YES; > CLANG_ENABLE_OBJC_ARC = YES; >Index: Tools/TestWebKitAPI/Configurations/Base.xcconfig >=================================================================== >--- Tools/TestWebKitAPI/Configurations/Base.xcconfig (revision 244754) >+++ Tools/TestWebKitAPI/Configurations/Base.xcconfig (working copy) >@@ -29,7 +29,7 @@ USE_INTERNAL_SDK_Production = YES; > USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK); > USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK); > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > CLANG_WARN_CXX0X_EXTENSIONS = NO; >Index: Tools/WebKitTestRunner/Configurations/Base.xcconfig >=================================================================== >--- Tools/WebKitTestRunner/Configurations/Base.xcconfig (revision 244754) >+++ Tools/WebKitTestRunner/Configurations/Base.xcconfig (working copy) >@@ -29,7 +29,7 @@ USE_INTERNAL_SDK_Production = YES; > USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK); > USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK); > >-CLANG_CXX_LANGUAGE_STANDARD = gnu++17; >+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z; > CLANG_CXX_LIBRARY = libc++; > CLANG_ENABLE_OBJC_WEAK = YES; > ENABLE_STRICT_OBJC_MSGSEND = YES;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 197388
: 368494