Attachment 368487 Details for Bug 197381 – Patch

[patch] Patch

bug-197381-20190429133952.patch (text/plain), 4.94 KB, created by Simon Fraser (smfr) on 2019-04-29 13:39:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-04-29 13:39:53 PDT

Size: 4.94 KB

patch

obsolete

>Subversion Revision: 244745
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dcb5cf3c13c0cd7f1ebdc6ff7ca01e51debf9199..c9e75e34d69fb4b2852d6fb1cdf56d44adfa56b3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-04-29  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site broken
>+        https://bugs.webkit.org/show_bug.cgi?id=197381
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: compositing/style-change/clip-path-change.html
>+
>+        * rendering/RenderLayerCompositor.cpp:
>+        (WebCore::recompositeChangeRequiresGeometryUpdate):
>+
> 2019-04-29  Chris Dumez  <cdumez@apple.com>
> 
>         User-facing strings should use curly quotes instead of straight
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>index 94f86ac00760464b8ffee55b32023174f341def3..bdf89dcbcd9a41c56a77fe1d1a7cd91f639aec20 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>@@ -1434,7 +1434,8 @@ static bool recompositeChangeRequiresGeometryUpdate(const RenderStyle& oldStyle,
>         || oldStyle.perspective() != newStyle.perspective()
>         || oldStyle.perspectiveOriginX() != newStyle.perspectiveOriginX()
>         || oldStyle.perspectiveOriginY() != newStyle.perspectiveOriginY()
>-        || oldStyle.backfaceVisibility() != newStyle.backfaceVisibility();
>+        || oldStyle.backfaceVisibility() != newStyle.backfaceVisibility()
>+        || !arePointingToEqualData(oldStyle.clipPath(), newStyle.clipPath());
> }
> 
> void RenderLayerCompositor::layerStyleChanged(StyleDifference diff, RenderLayer& layer, const RenderStyle* oldStyle)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ec96697efb4385097fdd60ecd9506c6a00f00fb2..814ddc5d69e6eaae861c7a35f01724a159169561 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-04-29  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site broken
>+        https://bugs.webkit.org/show_bug.cgi?id=197381
>+        <rdar://problem/50308128>
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        When -webkit-clip-path changes on a composited layer, we need to trigger a backing geometry update
>+        to push the changes to GraphicsLayers.
>+
>+        * compositing/style-change/clip-path-change-expected.html: Added.
>+        * compositing/style-change/clip-path-change.html: Added.
>+
> 2019-04-29  Youenn Fablet  <youenn@apple.com>
> 
>         RTCTrackEvent should be delayed until the whole remote description is set
>diff --git a/LayoutTests/compositing/style-change/clip-path-change-expected.html b/LayoutTests/compositing/style-change/clip-path-change-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..79edc9c6780d1eb1baa69b17d8af0b277ee24aee
>--- /dev/null
>+++ b/LayoutTests/compositing/style-change/clip-path-change-expected.html
>@@ -0,0 +1,26 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+    <style>
>+        .container {
>+            margin: 50px;
>+            height: 300px;
>+            width: 300px;
>+            border: 1px solid black;
>+        }
>+        
>+        .clipped {
>+            width: 100%;
>+            height: 100%;
>+            background-color: blue;
>+            transform: translateZ(0);
>+            -webkit-clip-path: circle(50% at center);
>+        }
>+    </style>
>+</head>
>+<body>
>+    <div class="container">
>+        <div class="clipped"></div>
>+    </div>
>+</body>
>+</html>
>diff --git a/LayoutTests/compositing/style-change/clip-path-change.html b/LayoutTests/compositing/style-change/clip-path-change.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..f385f94a101b29136139343ee2d89d47a1ea5be8
>--- /dev/null
>+++ b/LayoutTests/compositing/style-change/clip-path-change.html
>@@ -0,0 +1,42 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+    <style>
>+        .container {
>+            margin: 50px;
>+            height: 300px;
>+            width: 300px;
>+            border: 1px solid black;
>+        }
>+        
>+        .clipped {
>+            width: 100%;
>+            height: 100%;
>+            background-color: blue;
>+            transform: translateZ(0);
>+            -webkit-clip-path: circle(10% at center);
>+        }
>+        
>+        .clipped.changed {
>+            -webkit-clip-path: circle(50% at center);
>+        }
>+    </style>
>+    <script>
>+        if (window.testRunner)
>+            testRunner.waitUntilDone();
>+
>+        window.addEventListener('load', () => {
>+            setTimeout(() => {
>+                document.querySelector('.clipped').classList.add('changed');
>+                if (window.testRunner)
>+                    testRunner.notifyDone();
>+            }, 0);
>+        }, false);
>+    </script>
>+</head>
>+<body>
>+    <div class="container">
>+        <div class="clipped"></div>
>+    </div>
>+</body>
>+</html>

Flags:

zalan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197381: 368481 | 368487