Attachment 368480 Details for Bug 197375 – Patch

[patch] Patch

bug-197375-20190430061618.patch (text/plain), 1.49 KB, created by Dean Jackson on 2019-04-29 13:16:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2019-04-29 13:16:20 PDT

Size: 1.49 KB

patch

obsolete

>Subversion Revision: 244662
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e07c3e7f40751fa7e94ef5a8c38c9f52ccef1384..2fdc1fb6c15d20e54978719b0c20b56661227f55 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-04-29  Dean Jackson  <dino@apple.com>
>+
>+        Add InteractionIsHappening to SuppressSelectionAssistantReason
>+        https://bugs.webkit.org/show_bug.cgi?id=197375
>+        <rdar://problem/50304986>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a new reason for suppressing the selection assistant, to
>+        be used in a follow-up patch.
>+
>+        * UIProcess/ios/WKContentViewInteraction.h: Add InteractionIsHappening.
>+
> 2019-04-25  Brady Eidson  <beidson@apple.com>
> 
>         REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>index 107a27976d9df7286b3659eacc070c8dd95825dd..9c941e59a80ef7195a62e239d95f8e49739c3596 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>@@ -171,7 +171,8 @@ namespace WebKit {
> enum SuppressSelectionAssistantReason : uint8_t {
>     EditableRootIsTransparentOrFullyClipped = 1 << 0,
>     FocusedElementIsTooSmall = 1 << 1,
>-    DropAnimationIsRunning = 1 << 2
>+    DropAnimationIsRunning = 1 << 2,
>+    InteractionIsHappening = 1 << 3
> };
> 
> struct WKSelectionDrawingInfo {

Flags:

megan_gardner: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197375: 368480