Attachment 368470 Details for Bug 197206 – Build fix

[patch] Build fix

bug-197206-followup.diff (text/plain), 1.17 KB, created by Don Olmstead on 2019-04-29 11:29:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2019-04-29 11:29:10 PDT

Size: 1.17 KB

patch

obsolete

>diff --git a/ChangeLog b/ChangeLog
>index 319e3da8827..7548bd91c32 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-04-29  Don Olmstead  <don.olmstead@sony.com>
>+
>+        [CMake] Add WEBKIT_EXECUTABLE macro
>+        https://bugs.webkit.org/show_bug.cgi?id=197206
>+
>+        Unreviewed build fix.
>+
>+        Calls to add_dependencies were not happening.
>+
>+        * Source/cmake/WebKitMacros.cmake:
>+
> 2019-04-29  Basuke Suzuki  <Basuke.Suzuki@sony.com>
> 
>         [Win] Add flag to enable version information stamping and disable by default.
>diff --git a/Source/cmake/WebKitMacros.cmake b/Source/cmake/WebKitMacros.cmake
>index 48ee725c23f..4aacbd6ddc5 100644
>--- a/Source/cmake/WebKitMacros.cmake
>+++ b/Source/cmake/WebKitMacros.cmake
>@@ -170,8 +170,8 @@ macro(_WEBKIT_TARGET _target_logical_name _target_cmake_name)
> 
>     target_link_libraries(${_target_cmake_name} ${${_target_logical_name}_LIBRARIES})
> 
>-    if (${_target}_DEPENDENCIES)
>-        add_dependencies(${_target_cmake_name} ${${_target}_DEPENDENCIES})
>+    if (${_target_logical_name}_DEPENDENCIES)
>+        add_dependencies(${_target_cmake_name} ${${_target_logical_name}_DEPENDENCIES})
>     endif ()
> endmacro()
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197206: 368050 | 368052 | 368053 | 368054 | 368064 | 368155 | 368175 | 368332 | 368342 | 368347 | 368348 | 368360 | 368467 | 368470