WebKit Bugzilla
Attachment 368452 Details for
Bug 197366
: Add assertions to catch NetworkProcess null CompletionHandler dispatching
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-197366-20190429064834.patch (text/plain), 1.16 KB, created by
Alex Christensen
on 2019-04-29 06:48:35 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2019-04-29 06:48:35 PDT
Size:
1.16 KB
patch
obsolete
>Index: Source/WTF/ChangeLog >=================================================================== >--- Source/WTF/ChangeLog (revision 244732) >+++ Source/WTF/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2019-04-29 Alex Christensen <achristensen@webkit.org> >+ >+ Assert Function is non-null in RunLoop::dispatch >+ https://bugs.webkit.org/show_bug.cgi?id=197366 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * wtf/RunLoop.cpp: >+ (WTF::RunLoop::dispatch): >+ This will help us find the cause of rdar://problem/48679972 >+ > 2019-04-26 Don Olmstead <don.olmstead@sony.com> > > Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr >Index: Source/WTF/wtf/RunLoop.cpp >=================================================================== >--- Source/WTF/wtf/RunLoop.cpp (revision 244732) >+++ Source/WTF/wtf/RunLoop.cpp (working copy) >@@ -124,8 +124,9 @@ void RunLoop::performWork() > } > } > >-void RunLoop::dispatch(Function<void ()>&& function) >+void RunLoop::dispatch(Function<void()>&& function) > { >+ RELEASE_ASSERT(function); > { > auto locker = holdLock(m_functionQueueLock); > m_functionQueue.append(WTFMove(function));
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 197366
:
368452
|
369194
|
369236