Attachment 368390 Details for Bug 197337 – Patch

[patch] Patch

bug-197337-20190426234811.patch (text/plain), 3.92 KB, created by youenn fablet on 2019-04-26 23:48:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-04-26 23:48:13 PDT

Size: 3.92 KB

patch

obsolete

>Subversion Revision: 244694
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 69c97a99b8938d9c134f227a01e161929e7215f1..848c3d763dffb89a31363b6852839a011e6449b8 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-04-26  Youenn Fablet  <youenn@apple.com>
>+
>+        Kept alive loaders should use the redirected request in case of redirections
>+        https://bugs.webkit.org/show_bug.cgi?id=197337
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Instead of using the request, the redirected request should be used in case of redirection.
>+
>+        * NetworkProcess/NetworkResourceLoader.cpp:
>+        (WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
>+        (WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
>+
> 2019-04-26  Youenn Fablet  <youenn@apple.com>
> 
>         Use normal loading path for ping loads
>diff --git a/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp b/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>index 048f077f90bbceb276d452c3e90e0ebaf2e373aa..b29341334e9b3bf303c6fbce243b1e379f9bcedf 100644
>--- a/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>@@ -668,7 +668,7 @@ void NetworkResourceLoader::continueWillSendRedirectedRequest(ResourceRequest&&
>     ASSERT(!isSynchronous());
> 
>     if (m_isKeptAlive) {
>-        continueWillSendRequest(WTFMove(request), false);
>+        continueWillSendRequest(WTFMove(redirectRequest), false);
>         return;
>     }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4987ccfdeb24fad97bab9c065d31cd0fa70cebf9..2c644967d530ba8b5428671a0e9967f4deb633ad 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-04-26  Youenn Fablet  <youenn@apple.com>
>+
>+        Enable Fetch Keep Alive by default
>+        https://bugs.webkit.org/show_bug.cgi?id=197331
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt: Added.
>+
> 2019-04-26  Youenn Fablet  <youenn@apple.com>
> 
>         Use normal loading path for ping loads
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 3396ced2312272ad6a3d6151561c2ef12ad7caf2..076f6d2a859863a2bd1b1bd08decdd0573f91dee 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-04-26  Youenn Fablet  <youenn@apple.com>
>+
>+        Kept alive loaders should use the redirected request in case of redirections
>+        https://bugs.webkit.org/show_bug.cgi?id=197337
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/fetch/api/basic/keepalive-expected.txt:
>+
> 2019-04-26  Youenn Fablet  <youenn@apple.com>
> 
>         Use normal loading path for ping loads
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt
>index d5a2db9b0125b5a001b46da46eb8eaeb115c6927..f2aea85fd05c4b3fceb42d03c315d5dcf446ad2f 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt
>@@ -1,3 +1,3 @@
> 
>-FAIL Fetch API: keepalive handling assert_equals: expected (string) "on" but got (object) null
>+PASS Fetch API: keepalive handling 
> 
>diff --git a/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt b/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..d5a2db9b0125b5a001b46da46eb8eaeb115c6927
>--- /dev/null
>+++ b/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt
>@@ -0,0 +1,3 @@
>+
>+FAIL Fetch API: keepalive handling assert_equals: expected (string) "on" but got (object) null
>+

Actions: View | Formatted Diff | Diff

Attachments on bug 197337: 368374 | 368382 | 368384 | 368390