Attachment 368373 Details for Bug 197336 – Patch

[patch] Patch

bug-197336-20190426180825.patch (text/plain), 1.74 KB, created by Alex Christensen on 2019-04-26 18:08:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-04-26 18:08:25 PDT

Size: 1.74 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 244713)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-04-26  Alex Christensen  <achristensen@webkit.org>
>+
>+        Storage::deleteOldVersions does not need to retain Storage
>+        https://bugs.webkit.org/show_bug.cgi?id=197336
>+        <rdar://problem/48679972>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
>+        (WebKit::NetworkCache::Storage::deleteOldVersions):
>+        Something is wrong with the lifetime of Storage, but we only need a String, not the whole Storage.
>+
> 2019-04-26  Youenn Fablet  <youenn@apple.com>
> 
>         Use kDNSServiceFlagsKnownUnique to speed up mdns name registration for ICE candidates
>Index: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp	(revision 244694)
>+++ Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp	(working copy)
>@@ -1109,9 +1109,8 @@ void Storage::shrink()
> 
> void Storage::deleteOldVersions()
> {
>-    backgroundIOQueue().dispatch([this, protectedThis = makeRef(*this)] () mutable {
>-        auto cachePath = basePath();
>-        traverseDirectory(cachePath, [&cachePath](const String& subdirName, DirectoryEntryType type) {
>+    backgroundIOQueue().dispatch([cachePath = basePath()] () mutable {
>+        traverseDirectory(cachePath, [cachePath = WTFMove(cachePath)](const String& subdirName, DirectoryEntryType type) {
>             if (type != DirectoryEntryType::Directory)
>                 return;
>             if (!subdirName.startsWith(versionDirectoryPrefix))

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197336: 368373