Attachment 368295 Details for Bug 197303 – Patch

[patch] Patch

bug-197303-20190425185626.patch (text/plain), 5.66 KB, created by Said Abou-Hallawa on 2019-04-25 18:56:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Said Abou-Hallawa

Created: 2019-04-25 18:56:27 PDT

Size: 5.66 KB

patch

obsolete

>Subversion Revision: 244620
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8b5be61cd4d2706b12662b305733fcfe8586ad9b..09137bc111a800865063fbc9cceb8747f4698beb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-04-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
>+        https://bugs.webkit.org/show_bug.cgi?id=197303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Therefore SVGElement::propertyRegistry() was called instead. This means
>+        these two elements will not have access to the properties of the base
>+        class SVGFilterPrimitiveStandardAttributes.
>+
>+        Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg
>+
>+        * svg/SVGElement.cpp:
>+        (WebCore::SVGElement::commitPropertyChange):
>+        * svg/SVGFEFloodElement.h:
>+        * svg/SVGFEMergeElement.h:
>+
> 2019-04-24  Brady Eidson  <beidson@apple.com>
> 
>         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
>diff --git a/Source/WebCore/svg/SVGElement.cpp b/Source/WebCore/svg/SVGElement.cpp
>index 85d760072cabf1a11c4d4c7bf05b0b55c8ec34e4..cc5b6fd25e85b7f9ca9eca2e1aead4ef458f6189 100644
>--- a/Source/WebCore/svg/SVGElement.cpp
>+++ b/Source/WebCore/svg/SVGElement.cpp
>@@ -583,6 +583,7 @@ void SVGElement::commitPropertyChange(SVGProperty* property)
> void SVGElement::commitPropertyChange(SVGAnimatedProperty& animatedProperty)
> {
>     QualifiedName attributeName = propertyRegistry().animatedPropertyAttributeName(animatedProperty);
>+    ASSERT(attributeName != nullQName());
> 
>     // A change in a style property, e.g SVGRectElement::x should be serialized to
>     // the attribute immediately. Otherwise it is okay to be lazy in this regard.
>diff --git a/Source/WebCore/svg/SVGFEFloodElement.h b/Source/WebCore/svg/SVGFEFloodElement.h
>index b56135a7f481310d407cbee4de81ae708a796ef9..b96a43aa313e75e4a3167248a1b6f5cf51fee911 100644
>--- a/Source/WebCore/svg/SVGFEFloodElement.h
>+++ b/Source/WebCore/svg/SVGFEFloodElement.h
>@@ -32,8 +32,13 @@ public:
> private:
>     SVGFEFloodElement(const QualifiedName&, Document&);
> 
>+    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEFloodElement, SVGFilterPrimitiveStandardAttributes>;
>+    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
>+
>     bool setFilterEffectAttribute(FilterEffect*, const QualifiedName& attrName) override;
>     RefPtr<FilterEffect> build(SVGFilterBuilder*, Filter&) const override;
>+
>+    PropertyRegistry m_propertyRegistry { *this };
> };
> 
> } // namespace WebCore
>diff --git a/Source/WebCore/svg/SVGFEMergeElement.h b/Source/WebCore/svg/SVGFEMergeElement.h
>index 8433c9a481eae10d26aafd2611d47828473bd279..745086816f6976c6697dc51075802d283cf4e3c2 100644
>--- a/Source/WebCore/svg/SVGFEMergeElement.h
>+++ b/Source/WebCore/svg/SVGFEMergeElement.h
>@@ -32,7 +32,12 @@ public:
> private:
>     SVGFEMergeElement(const QualifiedName&, Document&);
> 
>+    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEMergeElement, SVGFilterPrimitiveStandardAttributes>;
>+    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
>+
>     RefPtr<FilterEffect> build(SVGFilterBuilder*, Filter&) const override;
>+
>+    PropertyRegistry m_propertyRegistry { *this };
> };
> 
> } // namespace WebCore
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index f8123ec8844f8924007b293dff6a6b2213413039..d1db223f4cfdd663bfd042140efe98e2bf368c42 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-04-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
>+        https://bugs.webkit.org/show_bug.cgi?id=197303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added.
>+        * svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added.
>+
> 2019-04-24  John Wilander  <wilander@apple.com>
> 
>         Age out unconverted Ad Click Attributions after one week.
>diff --git a/LayoutTests/svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg b/LayoutTests/svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg
>new file mode 100644
>index 0000000000000000000000000000000000000000..9d1424d1251234686a95be473212f560fd0afa8d
>--- /dev/null
>+++ b/LayoutTests/svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg
>@@ -0,0 +1,3 @@
>+<svg xmlns="http://www.w3.org/2000/svg">
>+    <rect x="10" y="10" width="100" height="100" fill="green"/>
>+</svg>
>diff --git a/LayoutTests/svg/dom/SVGFEFloodElement-filter-standard-attributes.svg b/LayoutTests/svg/dom/SVGFEFloodElement-filter-standard-attributes.svg
>new file mode 100644
>index 0000000000000000000000000000000000000000..cc29ca21ae41e21332ff3d59f11773ea4acd307b
>--- /dev/null
>+++ b/LayoutTests/svg/dom/SVGFEFloodElement-filter-standard-attributes.svg
>@@ -0,0 +1,15 @@
>+<svg xmlns="http://www.w3.org/2000/svg">
>+    <defs>
>+        <filter id="filter" filterUnits="userSpaceOnUse">
>+            <feFlood id="feFlood" x="0" y="0" width="50" height="50" flood-color="green"/>
>+        </filter>
>+    </defs>
>+    <use style="filter: url(#filter);"/>
>+    <script>
>+        var feFlood = document.querySelector("#feFlood");
>+        feFlood.x.baseVal.newValueSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_NUMBER, 10);
>+        feFlood.y.baseVal.newValueSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_NUMBER, 10);
>+        feFlood.width.baseVal.newValueSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_NUMBER, 100);
>+        feFlood.height.baseVal.newValueSpecifiedUnits(SVGLength.SVG_LENGTHTYPE_NUMBER, 100);
>+    </script>
>+</svg>

Actions: View | Formatted Diff | Diff

Attachments on bug 197303: 368295