Attachment 368290 Details for Bug 196633 – Patch

[patch] Patch

bug-196633-20190425171402.patch (text/plain), 5.67 KB, created by youenn fablet on 2019-04-25 17:14:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-04-25 17:14:03 PDT

Size: 5.67 KB

patch

obsolete

>Subversion Revision: 244579
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1fd62a9c4e72b6bf700f255543b0eb3664d817f2..3a279d5176796db9b95714209cafa0b63cf5f5d2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-04-25  Youenn Fablet  <youenn@apple.com>
>+
>+        [Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196633
>+        <rdar://problem/49627667>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use formula defined in https://w3c.github.io/webrtc-stats/#dom-rtcrtpcontributingsourcestats-audiolevel
>+        to compute the audio level from the RTP header information.
>+        Covered by rebased test.
>+
>+        * Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:
>+        (WebCore::fillRTCRtpContributingSource):
>+
> 2019-04-24  Youenn Fablet  <youenn@apple.com>
> 
>         Do not restart WebRTC stats timer if backend is stopped
>diff --git a/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp b/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp
>index f5a6ecf9b70f7cc7cbe714f18fdd99f5845ac87e..56f02c6c00b3c3084b461d72ffa92b326c840d56 100644
>--- a/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp
>+++ b/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp
>@@ -41,7 +41,7 @@ static inline void fillRTCRtpContributingSource(RTCRtpContributingSource& source
>     source.timestamp = rtcSource.timestamp_ms();
>     source.source = rtcSource.source_id();
>     if (rtcSource.audio_level())
>-        source.audioLevel = *rtcSource.audio_level();
>+        source.audioLevel = (*rtcSource.audio_level() == 127) ? 0 : pow(10, -*rtcSource.audio_level() / 20);
> }
> 
> static inline RTCRtpContributingSource toRTCRtpContributingSource(const webrtc::RtpSource& rtcSource)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 3b84875ec85c438eb210c4b58d3d67ed80d7cb95..5313ec23637fa60593620ca4e3408abe78c1cb73 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-04-25  Youenn Fablet  <youenn@apple.com>
>+
>+        [Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196633
>+        <rdar://problem/49627667>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-04-23  Youenn Fablet  <youenn@apple.com>
> 
>         Use normal loading path for ping loads
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 54836d5cb713483fa52a4d7bdbd5d06025cbc9c0..6f6c99197ae235c0c7219af5571e47d60e21d165 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-04-25  Youenn Fablet  <youenn@apple.com>
>+
>+        [Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196633
>+        <rdar://problem/49627667>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:
>+
> 2019-04-23  Youenn Fablet  <youenn@apple.com>
> 
>         Use normal loading path for ping loads
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt
>index 54ddfb9b51329af5938a32619cdea427e388870a..c9b3fdce33db594d506d23a3d7c952f2484d3fac 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt
>@@ -9,6 +9,6 @@ PASS [video] RTCRtpSynchronizationSource.timestamp is a number
> PASS [video] getSynchronizationSources() does not contain SSRCs older than 10 seconds 
> FAIL [video] RTCRtpSynchronizationSource.timestamp is comparable to performance.timeOrigin + performance.now() assert_true: expected true got false
> PASS [video] RTCRtpSynchronizationSource.source is a number 
>-FAIL [audio-only] RTCRtpSynchronizationSource.audioLevel is a number [0, 1] assert_less_than_equal: expected a number less than or equal to 1 but got 23
>+PASS [audio-only] RTCRtpSynchronizationSource.audioLevel is a number [0, 1] 
> FAIL [audio-only] RTCRtpSynchronizationSource.voiceActivityFlag is a boolean assert_equals: expected "boolean" but got "undefined"
> 
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 687e6d799fe7240296e57b2e23fc8fb2dc16aa7b..dd96ca63f1b89068e6182e746862a5884e708727 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -940,8 +940,6 @@ webkit.org/b/196448 [ Debug ] inspector/audit/basic.html [ Pass Timeout ]
> 
> webkit.org/b/194164 http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-but-access-from-wrong-frame.html [ Pass Timeout ]
> 
>-webkit.org/b/196633 imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html [ Pass Failure ]
>-
> webkit.org/b/195961 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex7-event_order.html [ Pass Failure ]
> webkit.org/b/195961 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html [ Pass Failure ]
>

Actions: View | Formatted Diff | Diff

Attachments on bug 196633: 368290