Attachment 368285 Details for Bug 197301 – Patch

[patch] Patch

bug-197301-20190425163754.patch (text/plain), 1.50 KB, created by youenn fablet on 2019-04-25 16:37:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-04-25 16:37:55 PDT

Size: 1.50 KB

patch

obsolete

>Subversion Revision: 244579
>diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog
>index bd2fd5295530e19a36a02dbbbc4dab5f28e09780..8b234a266ffe5b82dbbc1da2ec44fb2d7465a340 100644
>--- a/Source/ThirdParty/libwebrtc/ChangeLog
>+++ b/Source/ThirdParty/libwebrtc/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-04-25  Youenn Fablet  <youenn@apple.com>
>+
>+        Make sure sockets file descriptors are in the correct range
>+        https://bugs.webkit.org/show_bug.cgi?id=197301
>+        <rdar://problem/48389381>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/webrtc/rtc_base/physicalsocketserver.cc:
>+
> 2019-04-23  Alex Christensen  <achristensen@webkit.org>
> 
>         Add unit tests for WKWebView.serverTrust
>diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc
>index 7448a7e0427df2bbb7fbb28b21ee7664c69c4e03..91cb7da8366e2f1dfca360c57881f9707e54e008 100644
>--- a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc
>+++ b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc
>@@ -1424,6 +1424,8 @@ bool PhysicalSocketServer::WaitSelect(int cmsWait, bool process_io) {
>         // "select"ing a file descriptor that is equal to or larger than
>         // FD_SETSIZE will result in undefined behavior.
>         RTC_DCHECK_LT(fd, FD_SETSIZE);
>+        if (fd < 0 || fd >= FD_SETSIZE)
>+            continue;
>         if (fd > fdmax)
>           fdmax = fd;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197301: 368285 | 368287