Attachment 368269 Details for Bug 197295 – Patch

[patch] Patch

bug-197295-20190425141724.patch (text/plain), 1.95 KB, created by Timothy Hatcher on 2019-04-25 14:17:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2019-04-25 14:17:25 PDT

Size: 1.95 KB

patch

obsolete

>Subversion Revision: 244602
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 8e8baa819fb15ff8805961b54001600a3251bea7..0c9787079818c77d80686477b6ab0823e559d5d9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-04-25  Timothy Hatcher  <timothy@apple.com>
>+
>+        Only send a synthetic mouse out event if synthetic mouse move events were sent.
>+        https://bugs.webkit.org/show_bug.cgi?id=197295
>+        rdar://problem/49040233
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::completeSyntheticClick):
>+
> 2019-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Plumb the navigation's request when determining recommended compatibility mode
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index d4621ea988ae83087767680990830099b64766dc..986d22461fe4c7a9c9ac0cc10de44a9fa21e3efa 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -689,8 +689,10 @@ void WebPage::completeSyntheticClick(Node& nodeRespondingToClick, const WebCore:
>     if (newFocusedElement && newFocusedElement == oldFocusedElement)
>         elementDidRefocus(*newFocusedElement);
> 
>-    if (!tapWasHandled && nodeRespondingToClick.document().frame())
>+    // Only send a synthetic mouse out event if synthetic mouse move events were sent; this is true when ContentChangeObserver is enabled.
>+    if (nodeRespondingToClick.document().settings().contentChangeObserverEnabled() && !tapWasHandled && nodeRespondingToClick.document().frame())
>         nodeRespondingToClick.document().frame()->eventHandler().dispatchSyntheticMouseOut(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::NoType, 0, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
>+
>     if (m_isClosed)
>         return;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197295: 368269