Attachment 368261 Details for Bug 136627 – Patch

[patch] Patch

bug-136627-20190425164020.patch (text/plain), 1.78 KB, created by Gary Katsevman on 2019-04-25 13:40:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Gary Katsevman

Created: 2019-04-25 13:40:20 PDT

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 244654
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ab967c5b465dff86b6a301a758ff4a9820286b54..bce967c03e0408d6b62b9a25fe3f3c7333b74b3b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-04-25  Gary Katsevman  <git@gkatsev.com>
>+
>+        WebVTT: fix vertical cue alignment.
>+        https://bugs.webkit.org/show_bug.cgi?id=136627.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Tests already exist.
>+
>+        * html/track/VTTCue.cpp:
>+        (WebCore::VTTCueBox::applyCSSProperties):
>+
> 2019-04-25  Alex Christensen  <achristensen@webkit.org>
> 
>         Start using C++17
>diff --git a/Source/WebCore/html/track/VTTCue.cpp b/Source/WebCore/html/track/VTTCue.cpp
>index b67ede716dff5eb8079feb651b01a31d51216e67..10d5cc0625a906ee58a5192582261b0ce11f1297 100644
>--- a/Source/WebCore/html/track/VTTCue.cpp
>+++ b/Source/WebCore/html/track/VTTCue.cpp
>@@ -178,7 +178,10 @@ void VTTCueBox::applyCSSProperties(const IntSize& videoSize)
>     setInlineStyleProperty(CSSPropertyTop, position.second, CSSPrimitiveValue::CSS_PERCENTAGE);
> 
>     // the 'left' property must be set to left
>-    setInlineStyleProperty(CSSPropertyLeft, position.first, CSSPrimitiveValue::CSS_PERCENTAGE);
>+    if (cue->vertical() == horizontalKeyword())
>+        setInlineStyleProperty(CSSPropertyLeft, position.first, CSSPrimitiveValue::CSS_PERCENTAGE);
>+    else if (cue->vertical() == verticalGrowingRightKeyword())
>+        setInlineStyleProperty(CSSPropertyLeft, makeString("calc(-", FormattedNumber::fixedWidth(videoSize.width(), 2), "px - ", FormattedNumber::fixedWidth(cue->getCSSSize(), 2), "px)"));
> 
>     double authorFontSize = std::min(videoSize.width(), videoSize.height()) * DEFAULTCAPTIONFONTSIZEPERCENTAGE / 100.0;
>     double multiplier = 1.0;

Actions: View | Formatted Diff | Diff

Attachments on bug 136627: 368261 | 368294 | 368784 | 368789 | 368792 | 368802 | 368808 | 368811 | 368944 | 368947