Attachment 368242 Details for Bug 196357 – Patch

[patch] Patch

bug-196357-20190425100120.patch (text/plain), 6.68 KB, created by Sihui Liu on 2019-04-25 10:01:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-04-25 10:01:21 PDT

Size: 6.68 KB

patch

obsolete

>Subversion Revision: 244508
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8fd8b24e4f9ef5583a1527d0c0ba49b7cae4b1f1..c657cbe945416581cdacdaef3b1ad40bea7db721 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-04-25  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196357
>+        <rdar://problem/49386836>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched. IDBTransaction 
>+        is marked as finished before its event dispatched.
>+
>+        Covered by existing tests.
>+
>+        * Modules/indexeddb/IDBRequest.cpp:
>+        (WebCore::IDBRequest::dispatchEvent):
>+        * Modules/indexeddb/IDBTransaction.cpp:
>+        (WebCore::IDBTransaction::dispatchEvent):
>+        * Modules/indexeddb/IDBTransaction.h:
>+
> 2019-04-22  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext
>diff --git a/Source/WebCore/Modules/indexeddb/IDBRequest.cpp b/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
>index aa7543a1a3d4e52394691a947e1ccdc45beca69b..803ab1811a9ef09fb45b95b9a8ec703ed7baf1e8 100644
>--- a/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
>+++ b/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
>@@ -318,7 +318,7 @@ void IDBRequest::dispatchEvent(Event& event)
> 
>     if (&event == m_openDatabaseSuccessEvent)
>         m_openDatabaseSuccessEvent = nullptr;
>-    else if (m_transaction && !m_transaction->isFinished())
>+    else if (m_transaction && !m_transaction->isEventDispatched())
>         targets = { this, m_transaction.get(), &m_transaction->database() };
> 
>     m_hasPendingActivity = false;
>diff --git a/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp b/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
>index cb0397c48c6089626d8f70b5b5c8b5100ad7f967..201633a3416bf5cbcd5e7c6ca4803c6c635ebacc 100644
>--- a/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
>+++ b/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
>@@ -641,6 +641,7 @@ void IDBTransaction::dispatchEvent(Event& event)
>     auto protectedThis = makeRef(*this);
> 
>     EventDispatcher::dispatchEvent({ this, m_database.ptr() }, event);
>+    m_eventDispatched = true;
> 
>     if (isVersionChange()) {
>         ASSERT(m_openDBRequest);
>diff --git a/Source/WebCore/Modules/indexeddb/IDBTransaction.h b/Source/WebCore/Modules/indexeddb/IDBTransaction.h
>index 0313bf9116e2449cf5b810825f2ce93dbfb52e39..6203eb40fae977cf169085f96f38a82d6a7ffaa4 100644
>--- a/Source/WebCore/Modules/indexeddb/IDBTransaction.h
>+++ b/Source/WebCore/Modules/indexeddb/IDBTransaction.h
>@@ -146,6 +146,7 @@ public:
> 
>     bool isFinishedOrFinishing() const;
>     bool isFinished() const { return m_state == IndexedDB::TransactionState::Finished; }
>+    bool isEventDispatched() const { return m_eventDispatched; }
> 
>     IDBClient::IDBConnectionProxy& connectionProxy();
> 
>@@ -261,6 +262,7 @@ private:
>     RefPtr<IDBRequest> m_currentlyCompletingRequest;
> 
>     bool m_contextStopped { false };
>+    bool m_eventDispatched { false };
> };
> 
> class TransactionActivator {
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e06fb8458e23b1ecf52a4a565bc79275210d54f8..ae4faace3225eb474b7a3e9f1c71c606dd21ecbd 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-04-25  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196357
>+        <rdar://problem/49386836>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/ios-simulator-wk2/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+        * platform/mac/TestExpectations:
>+
> 2019-04-22  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext
>diff --git a/LayoutTests/platform/ios-simulator-wk2/TestExpectations b/LayoutTests/platform/ios-simulator-wk2/TestExpectations
>index cd8492952c35ba8209b73efe21fd87ecea7e65c5..4c025466b3c04b315982ac48fee64933892ad13e 100644
>--- a/LayoutTests/platform/ios-simulator-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-simulator-wk2/TestExpectations
>@@ -75,8 +75,6 @@ webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling
> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html [ Pass ImageOnlyFailure ]
> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html [ Pass ImageOnlyFailure ]
> 
>-webkit.org/b/196357 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html [ Pass Failure ]
>-
> http/wpt/cache-storage/quota-third-party.https.html [ Slow ]
> http/wpt/fetch/response-opaque-clone.html [ Slow ]
> 
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index a4b19dc39d0a4f66ba9cbbf5fd43ff6b8c158add..07bccceb51f63492d86be8d34613881ae7bed96a 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -673,8 +673,6 @@ webkit.org/b/171763 compositing/tiling/non-active-window-tiles-size.html [ Pass
> 
> webkit.org/b/171837 [ Debug ] http/tests/security/storage-blocking-loosened-plugin.html [ Pass Failure ]
> 
>-webkit.org/b/171862  storage/indexeddb/modern/idbtransaction-objectstore-failures.html [ Pass Failure ]
>-
> webkit.org/b/171935 [ Sierra ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]
> 
> webkit.org/b/171939 [ Sierra Release ] media/track/track-cue-rendering-on-resize.html [ Pass Timeout ]
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 66d0841f85017e584dd284555cf74f51dbd652f2..bcc584fad982161d816a1d4b3f79d6b5423f6ad9 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1593,8 +1593,6 @@ webkit.org/b/175998 http/tests/security/mixedContent/insecure-css-with-secure-co
> 
> webkit.org/b/165311 [ Sierra+ ] media/modern-media-controls/pip-support/pip-support-click.html [ Pass Failure ]
> 
>-webkit.org/b/176693 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html [ Pass Failure ]
>-
> # User-installed font infrastructure is ony present on certain OSes.
> webkit.org/b/180062 [ Sierra HighSierra ] fast/text/user-installed-fonts/disable.html [ ImageOnlyFailure ]
> webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript.html [ ImageOnlyFailure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 196357: 368242 | 368293