Attachment 368241 Details for Bug 197284 – Patch

[patch] Patch

bug-197284-20190425094439.patch (text/plain), 1.56 KB, created by Brady Eidson on 2019-04-25 09:44:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brady Eidson

Created: 2019-04-25 09:44:40 PDT

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 244569
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dad856a9fb299e2365111e02edb4bde3c87206b8..2d084d496411b864441cd0e5959453f92a60ce4a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-04-25  Brady Eidson  <beidson@apple.com>
>+
>+        REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
>+        <rdar://problem/49755494> and https://bugs.webkit.org/show_bug.cgi?id=197284
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/cocoa/WebProcessCocoa.mm:
>+        (WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should
>+          be eligible. Only if all pages are suspended should it be jetsam-able.
>+
> 2019-04-23  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r244556.
>diff --git a/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm b/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
>index f00d780543a7f701aefd3ccdec59248e04147e1d..73df75c86dda1237eaf5b9cc4d33639dbc83117d 100644
>--- a/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
>+++ b/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
>@@ -733,10 +733,11 @@ bool WebProcess::shouldFreezeOnSuspension() const
> 
>     for (auto& page : m_pageMap.values()) {
>         if (!page->isSuspended())
>-            return false;
>+            return true;
>     }
> 
>-    return true;
>+    // Since all of the pages in this process were suspended, we should not bother freezing it.
>+    return false;
> }
> 
> void WebProcess::updateFreezerStatus()

Actions: View | Formatted Diff | Diff

Attachments on bug 197284: 368241